Patch - Mehah viewportcontrol#1097
Closed
4drik wants to merge 8 commits into
Closed
Conversation
Better manage of view range
Current OTClient drawFlags solution is left intact
Mehah solution
Mehah solution
Collaborator
|
Thanks for taking the time to make this change a proper PR, could you perhaps rename the files |
Collaborator
|
Personally I believe there are a lot of issues with this approach / code such as:
To be honest all of it seems to be over-complicated. Please note this is my personal opinion. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A review of viewportcontrol by mehah